fix: side effect imports (#584)

Co-authored-by: Javier Rivas <JRivas@experianinteractive.com>
BuilderIO · Jul 21, 2022 · dae644a · dae644a · vercel · Jul 21, 2022
1 parent a51701e
commit dae644a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/core/src/helpers/render-imports.test.ts b/packages/core/src/helpers/render-imports.test.ts
@@ -15,4 +15,19 @@ describe('renderImport', () => {
     });
     expect(output).toMatchSnapshot();
   });
+
+  test('Adds correctly a side-effect import', () => {
+    const data = [
+      {
+        imports: {},
+        path: '../render-blocks.scss',
+      },
+    ];
+    const output = renderImport({
+      theImport: data[0],
+      target: 'react',
+      asyncComponentImports: false,
+    });
+    expect(output).toEqual("import '../render-blocks.scss';");
+  });
 });
diff --git a/packages/core/src/helpers/render-imports.ts b/packages/core/src/helpers/render-imports.ts
@@ -119,7 +119,7 @@ export const renderImport = ({
     }
   }
 
-  return `import ${importValue} from '${path}';`;
+  return importValue ? `import ${importValue} from '${path}';` : `import '${path}';`;
 };
 
 export const renderImports = ({
-Original file line number
+Diff line change
@@ Expand Up / @@ -119,7 +119,7 @@ export const renderImport = ({ @@
         }
       }
-      return `import ${importValue} from '${path}';`;
+      return importValue ? `import ${importValue} from '${path}';` : `import '${path}';`;
     };
     export const renderImports = ({
@@ Expand Down @@