fix[sdks]: centering items in columns #3979
Merged
+175
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 12c81b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 12c81b3.
☁️ Nx Cloud last updated this comment at |
sidmohanty11
requested review from
a team,
builder-adi,
anaghav2023 and
clyde-builderio
and removed request for
a team,
builder-adi and
anaghav2023
Comment on lines
+622
to
+623
| expect(textCenters[0]).toBeCloseTo(columnCenter, 1); | ||
| expect(textCenters[1]).toBeCloseTo(columnCenter, 1); |
There was a problem hiding this comment.
Here textCenters[0] should be equal to textCenters[1] ?
There was a problem hiding this comment.
yup, both are vertically centered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when we vertically center two individual elements we use
margin-top: auto,margin-bottom: autoto keep the elements in the center. Turns out the builder-columns box doesn't respect height and shrinks to what’s required and height gets applied to the root div (as we don’t use noWrap true in case of columns). To fix this, we are addingheight: 100%to make sure that we respect the root div's height (if provided)Jira
https://builder-io.atlassian.net/browse/ENG-8386
Screenshot
If relevant, add a screenshot or two of the changes you made.