Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS V2 Step bindings parsing and JS quote pattern update #15734

Merged
merged 2 commits into from
Mar 13, 2025

Conversation

deanhannigan
Copy link
Contributor

Description

JS Bindings in the JavaScript V2 step in automations were not properly processing to their runtime state on blur.

Updated the JS binding parsing pattern to allow more flexibility with quote choice. This should better accomodate manual user entry of bindings.

// Default
$("Current User.firstName")

// Now parsable
$('Current User.firstName')
$(`Current User.firstName`)

Addresses

Screenshots

All parsable and valid.
Screenshot 2025-03-13 at 10 12 02

Launchcontrol

Updated readable JS binding pattern matching in the builder and added a fix for JS V2 JS binding parsing.

Copy link

qa-wolf bot commented Mar 13, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@deanhannigan deanhannigan changed the title Ensure values typed in the JS step node are properly converted. Allow… JS V2 Step bindings parsing and JS quote pattern update Mar 13, 2025
@deanhannigan deanhannigan merged commit 12e87f0 into master Mar 13, 2025
22 checks passed
@deanhannigan deanhannigan deleted the fix/readable-binding-quotes branch March 13, 2025 10:32
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants