Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type fields #15706

Merged
merged 15 commits into from
Mar 13, 2025
Merged

Type fields #15706

merged 15 commits into from
Mar 13, 2025
+153 −80

Conversation

adrinr
Copy link
Collaborator

@adrinr adrinr commented Mar 10, 2025 •
edited
Loading

Description

Type fields components

@linear Linear
Copy link

linear bot commented Mar 10, 2025

BUDI-9077 User does not have permission error shows up due to relationship column being set to read only on a view.

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Mar 10, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@adrinr adrinr marked this pull request as draft March 10, 2025 12:20
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/s labels Mar 10, 2025
@github-actions github-actions bot added size/m and removed size/s labels Mar 10, 2025
adrinr added 3 commits March 10, 2025 16:54
@adrinr
Extra typings
48b4bf6
@adrinr
Type
Loading
Loading status checks…
e9286c8
@adrinr
Lint
Loading
Loading status checks…
482bc98
@adrinr adrinr marked this pull request as ready for review March 10, 2025 17:31
aptkingston
aptkingston reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good, just one question about where we store all these new types 👍

Base automatically changed from types/check-types-in-client to master March 11, 2025 11:12
@adrinr
Move types around
Loading
Loading status checks…
10737c8
@adrinr adrinr requested a review from aptkingston March 11, 2025 11:24
adrinr added 2 commits March 11, 2025 12:27
@adrinr
lint:fix
Loading
Loading status checks…
1957dcf
@adrinr
lint:fix
Loading
Loading status checks…
e74ed06
aptkingston
aptkingston approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@aptkingston aptkingston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrinr adrinr enabled auto-merge March 11, 2025 13:05
adrinr added 2 commits March 11, 2025 14:05
@adrinr
Merge branch 'master' into BUDI-9077/type-fields

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
a84e22e
@adrinr
Merge branch 'master' into BUDI-9077/type-fields

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6092d57
@adrinr adrinr merged commit b063fab into master Mar 13, 2025
22 checks passed
@adrinr adrinr deleted the BUDI-9077/type-fields branch March 13, 2025 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aptkingston aptkingston

@mike12345567 mike12345567

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrinr @aptkingston