Typescript conversion for some BBUI components #15623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adrinr
reviewed
Feb 28, 2025
| export const createNotificationStore = () => { | ||
| const timeoutIds = new Set() | ||
| const _notifications = writable([], () => { | ||
| const timeoutIds = new Set<NodeJS.Timeout>() |
There was a problem hiding this comment.
We had some issues with this when running on the frontend.
Suggested change
| const timeoutIds = new Set<NodeJS.Timeout>() | |
| const timeoutIds = new Set<ReturnType<typeof setTimeout>>() |
adrinr
reviewed
Feb 28, 2025
| export let schema: any | ||
| export let value: any | ||
| export let customRenderers: { column: string; component: any }[] = [] | ||
| export let snippets: any |
|
|
||
| // adding the 0- will turn a string like 00:00:00 into a valid ISO | ||
| // date, but will make actual ISO dates invalid | ||
| $: time = new Date(`0-${value}`) | ||
| $: isTimeOnly = !isNaN(time) || schema?.timeOnly | ||
| $: isTimeOnly = !isNaN(time.getTime()) || schema?.timeOnly |
There was a problem hiding this comment.
Is this expected? Would this not change its behaviour?
There was a problem hiding this comment.
So isNan only takes a number, but we were passing a date to it here, but it was getting coerced internally by isNan. I've casted it to any instead, just to be safe in this instance and to not change any behaviour it relies on.
…ons' into feat/pc-ts-conversions
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts a number of BBUI components to Typescript