Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve typing around plugins. #15619

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Improve typing around plugins. #15619

merged 7 commits into from
Feb 27, 2025

Conversation

samwho
Copy link
Collaborator

@samwho samwho commented Feb 25, 2025 •
edited
Loading

@samwho samwho requested a review from a team as a code owner February 25, 2025 11:03
@samwho samwho requested review from adrinr and removed request for a team February 25, 2025 11:03
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Feb 25, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@samwho samwho requested review from mike12345567 and removed request for adrinr February 25, 2025 11:03
@github-actions github-actions bot added firestorm Data/Infra/Revenue Team size/m labels Feb 25, 2025
mike12345567
mike12345567 approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@mike12345567 mike12345567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samwho samwho enabled auto-merge February 27, 2025 09:40
@samwho samwho merged commit 0a8cf31 into master Feb 27, 2025
21 checks passed
@samwho samwho deleted the plugin-typing branch February 27, 2025 09:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mike12345567 mike12345567 mike12345567 approved these changes

Assignees
No one assigned
Labels
firestorm Data/Infra/Revenue Team size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samwho @mike12345567