Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/bi 2352 #159

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Feature/bi 2352 #159

merged 2 commits into from
Mar 12, 2025

Conversation

cvacalares
Copy link
Collaborator

Description

BI-2352 - Read Only permission for Cucumber Member

Testing

Please include a link to a successful run of TAF for this change

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

@cvacalares cvacalares requested review from a team, HMS17 and mlm483 and removed request for a team February 6, 2025 08:21
HMS17
HMS17 requested changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@HMS17 HMS17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the cucumber run does not include the scenario added and thereby needing to be tested, likely because of the debug tag?

@cvacalares
Copy link
Collaborator Author

image
It was part of the test result.
We don't have any filter on our full run.

@HMS17 HMS17 self-requested a review March 10, 2025 13:47
@cvacalares cvacalares merged commit e4ae1eb into develop Mar 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HMS17 HMS17 HMS17 approved these changes

@mlm483 mlm483 mlm483 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvacalares @HMS17 @mlm483