Add test for BI-2000. Add bad ontology sample. #150
Conversation
cvacalares
requested review from
a team,
HMS17 and
mlm483
and removed request for
a team
src/features/BI-2000.feature
Outdated
| And user uploads Ontology "test01-ontology.xls" file | ||
| And user selects 'Import' button | ||
| When user selects "Confirm" button | ||
| Then user can see banner contains "Imported ontology terms have been added" |
There was a problem hiding this comment.
Given the acceptance criteria includes "THEN the user can see the error message disappear when a valid file is uploaded." should there be a "user can see banner does NOT contain 'THEN the user can see the error message disappear when a valid file is uploaded. '" clause?
There was a problem hiding this comment.
I have updated to add the "Then user cannot see banner contains "Error(s) detected in file, Bad.xls . (See details below.) Import cannot proceed.".
… detected in file, Bad.xls . (See details below.) Import cannot proceed.".
| "chromedriver": "^127.0.0", | ||
| "chromedriver": "^129.0.0", |
There was a problem hiding this comment.
Aren't we pinning the chrome version in the GitHub Actions? Do they need to be updated as well?
There was a problem hiding this comment.
That I'm not aware. I usually update the package.json.
There was a problem hiding this comment.
Well, it looks like it ran without any chromedriver issues.
Description
Add test for BI-2000.
Testing
Please include a link to a successful run of TAF for this change
Checklist: