Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BI-1692] - Change role names #142

Merged
merged 3 commits into from
Aug 8, 2024
Merged

[BI-1692] - Change role names #142

merged 3 commits into from
Aug 8, 2024

Conversation

HMS17
Copy link
Contributor

@HMS17 HMS17 commented Jul 25, 2024

Description

Story: BI-1692 - Change role names
TAF changes in response to changing role domains as follows:

  • admin -> System Administrator
  • breeder -> Program Administrator
  • member -> Read Only

Areas updated to use new role domains:

  • README
  • populate-taf-data.sql
  • Features
  • Step definitions

Dependencies

bi-web: feature/BI-1692
bi-api: feature/BI-1692

Testing

Please include a link to a successful run of TAF for this change

Checklist:

  • I have performed a self-review of my own code
  • I have tested my code and ensured it meets the acceptance criteria of the story
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to documentation

@HMS17 HMS17 changed the title [BI-1692] - Fixing TAF scenarios [BI-1692] - Change role names Jul 25, 2024
@cvacalares cvacalares self-requested a review July 29, 2024 22:57
Copy link
Collaborator

@cvacalares cvacalares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HMS17 HMS17 requested review from davedrp and nickpalladino August 6, 2024 11:26
@HMS17 HMS17 marked this pull request as ready for review August 6, 2024 11:26
@@ -15,7 +15,7 @@ Feature: Logging with Member
And user can see "Program Administration" in navigation

@BI-823
Scenario: Logging in as a breeder of one program
Scenario: Logging in as a Read Only of one program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an issue in the description of the test?

@@ -28,14 +28,14 @@ Feature: Logging with Member
And user can see "Program Administration" in navigation

@BI-845
Scenario: Logging in as a breeder of one program
Scenario: Logging in as a Read Only of one program
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this was just a labeling issue of the scenario like the last one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I figured I might as well fix the labels since I was changing them anyway.

@nickpalladino nickpalladino self-requested a review August 6, 2024 17:59
@HMS17 HMS17 requested review from mlm483 and removed request for davedrp August 7, 2024 15:00
@HMS17 HMS17 merged commit a6bd46c into develop Aug 8, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants