BI-2377 - Add Delete Option to Experiments View #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davedrp
requested review from
a team,
dmeidlin and
nickpalladino
and removed request for
a team
dmeidlin
reviewed
Jan 13, 2025
Comment on lines
18
to
51
| <template> | ||
| <section | ||
| v-bind:id="'deleteModal-' + uniqueId" | ||
| v-bind:class="modalClass" | ||
| > | ||
| <FormModal | ||
| v-bind:active.sync="active" | ||
| v-bind:title="modalTitle" | ||
| v-on:deactivate="closeDeleteModal" | ||
| > | ||
| <template #form> | ||
| <slot name="form" /> | ||
| </template> | ||
| <template #buttons> | ||
| <div class="columns"> | ||
| <div class="column is-whole has-text-centered buttons"> | ||
| <button | ||
| class="button is-primary has-text-weight-bold" | ||
| v-on:click="invokeDeleteAction" | ||
| > | ||
| <strong>Yes</strong> | ||
| </button> | ||
| <button | ||
| class="button" | ||
| v-on:click="closeDeleteModal" | ||
| > | ||
| Cancel | ||
| </button> | ||
| </div> | ||
| </div> | ||
| </template> | ||
| </FormModal> | ||
| </section> | ||
| </template> |
There was a problem hiding this comment.
This modal seems to be based off of /src/components/modals/ConfirmationModal.vue. The germplasm list delete uses ConfirmationModal.vue in the same way DeleteModal is being used here. Is there a reason to add a new modal component or can ConfirmationModal.vue be used for experiments as well?
dmeidlin
reviewed
Jan 13, 2025
src/config/AppAbility.ts
Outdated
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| import {Ability, AbilityClass} from '@casl/ability'; | |||
|
|
|||
| type Actions = 'manage' | 'create' | 'read' | 'update' | 'delete' | 'archive' | 'access' | 'submit'; | |||
| type Actions = 'manage' | 'delete' |'create' | 'read' | 'update' | 'delete' | 'archive' | 'access' | 'submit'; | |||
There was a problem hiding this comment.
'delete' is already present between update and archive and shouldn't need to be added again.
There was a problem hiding this comment.
Thank you.
Implemented.
davedrp
force-pushed
the
feature/BI-2377
branch
from
316f1e1 to
8146a9e
Compare
davedrp
changed the title
dmeidlin
approved these changes
Jan 15, 2025
|
@nickpalladino The success notification was aded |
davedrp
force-pushed
the
feature/BI-2377
branch
from
0922fff to
a4fdc69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BI-2377 Add Delete Option to Experiments View
Also fixed one accessibility issue ("Text not included in an ARIA landmark")
Dependencies
bi-api: develop
brapi-Java-TestServer: develop (be sure to pull the latest version. there is a needed bug fix)
Testing
Checklist: