35 feature request implement code review suggestions #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MarcelRosier
commented
Feb 26, 2024
MarcelRosier
commented
- Merge GPU/ CPU class into one that auto sets the best device (forced CPU possible!)
- Separate concerns: Outsource data and model handling to separate classes.
- Adapt tests accordingly
- Improve docs, logging, cleanness
- Attempts to fix LoadImaged warning
- Add Support for Py 3.8, 3.9 (supports typing via future import)
- sort imports
- added option to specify device on config
- rm unneeded arg to test
- testwise lower limit py3.8
This was
linked to
issues
Feb 26, 2024
neuronflow
approved these changes
Feb 27, 2024
neuronflow
deleted the
35-feature-request-implement-code-review-suggestions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.