Fixes #466. Adds support for header highlighting using intersection o… #580
Conversation
|
There's an issue that I'm not sure how to solve -
The current header is decided based on the proximity of a heading to the top of the viewport. To be precise, if a heading is 100px within the top corner of the viewport it is marked as the current heading. Problem is with this heading at the bottom, it never gets close to 100px of the top of the viewport. |
|
@ssddanbrown - Do you think we should add a scroll event check, and if the user has reached the bottom of the page, we highlight the last header in the page nav? |
|
@Abijeet Sorry for the delay in my response. I know its not conventional by maybe, instead of guessing what the user is viewing (By what's near the top of the page), we highlight all sections currently in view? |
Getting the latest changes.
… appearing in Firefox.
| @@ -135,7 +135,7 @@ body.flexbox { | |||
| width: 30%; | |||
| left: 0; | |||
| height: 100%; | |||
| overflow-y: scroll; | |||
| overflow-y: auto; | |||
There was a problem hiding this comment.
Firefox 57 adds a scrollbar with overflow-y: scroll.
|
Like you said, it's unconventional but I've gone ahead and done that since that seemed like the "correct" thing to do. Here is how it looks now -
In addition, a property in _grid.scss was causing a scrollbar to appear in Firefox 57. I've fixed that as well -
|
|
Thank again @Abijeet, Now merged. |
…bserver.