Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added standard JS formatting via ESLint #4181

Merged
merged 5 commits into from
Apr 19, 2023
Merged

Added standard JS formatting via ESLint #4181

merged 5 commits into from
Apr 19, 2023

Conversation

ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Apr 18, 2023 •
edited
Loading

Closes #4180

Todo

  • Fix existing 577 reported issues 😟
  • Add details of new linting NPM scripts/commands to dev docs
  • Add to actions (Maybe existing PHP lint action)

Handy Links

@ssddanbrown
Added code formatting standard via eslint
752ee66
@ssddanbrown
Ran eslint fix on existing codebase
e711290 
Had to do some manual fixing of the app.js file due to misplaced
comments
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Apr 18, 2023
@ssddanbrown ssddanbrown self-assigned this Apr 18, 2023
@ssddanbrown ssddanbrown merged commit 9f467f4 into development Apr 19, 2023
@ssddanbrown ssddanbrown deleted the js_formatting branch April 19, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ssddanbrown ssddanbrown

Labels
💻 Front-End :octocat: Admin/Meta 🔧 Maintenance
Milestone
v23.05
Development

Successfully merging this pull request may close these issues.

Add formatter for JS codebase
1 participant
@ssddanbrown