Skip to content

Commit

Permalink
feat(ubuntu 18): Add support for Ubuntu 18.04
Browse files Browse the repository at this point in the history
- added ubuntu 18 in the list of supported OS for the easy install
script
- ensured the install script for mariadb which works on ubuntu xenial
also works on ubuntu bionic
- sidenote: prevented pip from installing requests, since a system
package is already installed in centos 7

Signed-off-by: Ameya Shenoy <shenoy.ameya@gmail.com>
  • Loading branch information
codingCoffee committed Sep 16, 2018
1 parent 2e7619c commit de94469
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions playbooks/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def install_bench(args):
# secure pip installation
if find_executable('pip'):
run_os_command({
'pip': 'sudo pip install --upgrade setuptools urllib3 requests cryptography pip'
'pip': 'sudo pip install --upgrade setuptools urllib3 cryptography pip'
})

else:
Expand All @@ -55,7 +55,7 @@ def install_bench(args):
})

success = run_os_command({
'pip': "sudo pip install --upgrade urllib3 requests cryptography ansible"
'pip': "sudo pip install --upgrade urllib3 cryptography ansible"
})

if not success:
Expand Down Expand Up @@ -129,7 +129,7 @@ def install_bench(args):
shutil.rmtree(tmp_bench_repo)

def check_distribution_compatibility():
supported_dists = {'ubuntu': [14, 15, 16], 'debian': [8, 9],
supported_dists = {'ubuntu': [14, 15, 16, 18], 'debian': [8, 9],
'centos': [7], 'macos': [10.9, 10.10, 10.11, 10.12]}

dist_name, dist_version = get_distribution_info()
Expand Down
4 changes: 2 additions & 2 deletions playbooks/roles/mariadb/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
- include: ubuntu-trusty.yml
when: ansible_distribution == 'Ubuntu' and ansible_distribution_version == '14.04'

- include: ubuntu-xenial.yml
when: ansible_distribution == 'Ubuntu' and ansible_distribution_version == '16.04'
- include: ubuntu-xenial_bionic.yml
when: ansible_distribution == 'Ubuntu' and ansible_distribution_major_version|int >= 16

- name: Add configuration
template: src={{ mysql_conf_tpl }} dest={{ mysql_conf_dir[ansible_distribution] }}/{{ mysql_conf_file }} owner=root group=root mode=0644
Expand Down

0 comments on commit de94469

Please sign in to comment.