Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support getting HTML as stream #83

Closed
S-Luiten opened this issue Jan 3, 2025 · 0 comments · Fixed by #85
Closed

[Feature Request] Support getting HTML as stream #83

S-Luiten opened this issue Jan 3, 2025 · 0 comments · Fixed by #85
Labels
Feature Request New feature or request Triage Issue needs to be triaged

Comments

@S-Luiten
Copy link
Contributor

S-Luiten commented Jan 3, 2025

Is your feature request related to a problem? Please describe.
As mentioned in #77, there's a limit of 32kB when getting HTML content, making it impossible to include large strings or images.

Describe the solution you'd like
Same solution as in https://github.com/aspnet/samples/tree/main/samples/aspnetcore/blazor/InputLargeTextArea
This solution uses IJSStreamReference which requires .NET 6.0 or later. To prevent breaking changes, the library can use multiple target frameworks, but then the solution will not be available in the .NET standard 2.0 version.

Describe alternatives you've considered
The 32kB limit can be increased through Microsoft.AspNetCore.SignalR.HubOptions.MaximumReceiveMessageSize, but this is not recommended by Microsoft due to becoming more vulnerable to DoS attacks.

Additional context
I'm willing to make a PR for this.

@S-Luiten S-Luiten added Feature Request New feature or request Triage Issue needs to be triaged labels Jan 3, 2025
ADefWebserver added a commit that referenced this issue Jan 3, 2025
Add GetHTMLAsStream method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Triage Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant