Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add overloads with CancellationToken parameter to async methods. #76

Closed
S-Luiten opened this issue Dec 12, 2024 · 1 comment · Fixed by #77
Closed
Labels
Feature Request New feature or request Triage Issue needs to be triaged

Comments

@S-Luiten
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I'd like to add a timeout to GetHTML using a CancellationTokenSource. However, this method does not take a CancellationToken.

Describe the solution you'd like
An overload for GetHTML and other async methods which takes a cancellationToken parameter and passes it to jsRuntime.InvokeAsync.

Describe alternatives you've considered
Due to requiring a reference to the private field QuillElement, I'm currently forced to use reflection to get this reference, and manually call jsRuntime.InvokeAsync.

@S-Luiten S-Luiten added Feature Request New feature or request Triage Issue needs to be triaged labels Dec 12, 2024
@ADefWebserver
Copy link
Collaborator

I will consider a PR for this.

S-Luiten added a commit to S-Luiten/TextEditor that referenced this issue Dec 31, 2024
ADefWebserver added a commit that referenced this issue Dec 31, 2024
Add CancellationToken overloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request Triage Issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants