Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-283 Add PayU error handling, updatede and run ECS #60

Merged
merged 5 commits into from
Jun 10, 2024
Merged

OP-283 Add PayU error handling, updatede and run ECS #60

merged 5 commits into from
Jun 10, 2024

Conversation

SzymonKostrubiec
Copy link

  • Update and run ECS
  • Added EventListener to handle payment gateway errors.

senghe
senghe reviewed May 24, 2024
View reviewed changes
Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems to be good. Please fix issues from comments, write tests and then ask for re-review :)

senghe
senghe approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@senghe senghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve in advance. Please switch the order of OS header and the declare statement and you can go with testing.

@senghe senghe merged commit 8b4b7cb into BitBagCommerce:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senghe senghe senghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SzymonKostrubiec @senghe