feat!: Added nameTextStyle

[vanlooverenkoen]

Description

Add support for name text styles to make sure your background & text color still readable

Type of Change

• ✨ New feature (non-breaking change which adds functionality)
• 🛠️ Bug fix (non-breaking change which fixes an issue)
• ❌ Breaking change (fix or feature that would cause existing functionality to change)
• 🧹 Code refactor
• ✅ Build configuration change
• 📝 Documentation
• 🗑️ Chore

[btrautmann]

let's add a test

also, I'll re-generate goldens via CI before merge rather than having you do it locally to ensure we don't see breakages on CI.

[vanlooverenkoen]

Test added ✅

[jeroen-meijer]

Couple comments, I'll leave most of the review process to @btrautmann since he has more context.

If you ask me, LGTM.

[jeroen-meijer]

General question: why is this PR considered breaking? Seems like all that's being done is add an optional property 👀

[vanlooverenkoen]

required this.nameTextStyle,

[btrautmann]

Yeah, this tracks, as if you were using the constructor directly you'd break when updating. It begs the question whether we should've made that constructor public or whether all properties should be optional since all our defaults will likely be const anyway. Either way, I don't think that's something we need to solve as part of this PR.

[btrautmann]

@vanlooverenkoen can you actually revert the change you made to the golden image? It's failing on CI because of a very minor difference between the image being generated on (what I assume is) macOS (your host machine) and CI. If you revert it, it will fail locally for you but pass on CI which is correct/desired (well, not "desired" but the platform-rendering-difference is out of our control).

[jeroen-meijer]

(well, not "desired" but the platform-rendering-difference is out of our control).

Funny, that's the whole reason we made Alchemist 😆

[vanlooverenkoen]

@btrautmann I have reverted the golden tests

[btrautmann]

domain lgtm
platform lgtm