Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement Parsing Fixes #299

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Requirement Parsing Fixes #299

merged 2 commits into from
Aug 14, 2024

Conversation

Eric-Vin
Copy link
Collaborator

@Eric-Vin Eric-Vin commented Aug 6, 2024

Description

Fixes Issue #296

Issue Link

#296

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin requested a review from dfremont August 6, 2024 01:22
@Eric-Vin Eric-Vin linked an issue Aug 6, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (5f134ad) to head (e84f3e0).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
- Coverage   91.36%   91.29%   -0.08%     
==========================================
  Files          54       54              
  Lines       13537    13528       -9     
==========================================
- Hits        12368    12350      -18     
- Misses       1169     1178       +9     
Files Coverage Δ
src/scenic/syntax/compiler.py 98.47% <100.00%> (-0.01%) ⬇️

... and 6 files with indirect coverage changes

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! If you can double-check this fixes the example in #296, please go ahead and merge.

@Eric-Vin Eric-Vin merged commit 50eed8e into main Aug 14, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean operators don't work deep inside a requirement
2 participants