Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean gulp completions #2137

Closed
wants to merge 2 commits into from
Closed

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Mar 15, 2022

Description

Similar fix as defined in #2136

Motivation and Context

Help clean bashit #1696

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

}
complete -o default -F _gulp_completions gulp
if _command_exists gulp; then
eval "$(gulp --completion=bash)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also does not always work sadly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NoahGorny It is working

 2022-05-20 08:00:37 ⌚  36f05b99f861 in /my-project
○ → git clone --branch improve/gulp-completion  https://github.com/tbhaxor/bash-it.git ~/.bash_it -q

 2022-05-20 08:00:45 ⌚  36f05b99f861 in /my-project
○ → ~/.bash_it/install.sh 

 2022-05-20 08:00:52 ⌚  36f05b99f861 in /my-project
○ → cat ~/.bash_it/completion/available/gulp.completion.bash 
# shellcheck shell=bash

if _command_exists gulp; then
        eval "$(gulp --completion=bash)"
fi

 2022-05-20 08:01:07 ⌚  36f05b99f861 in /my-project
○ → bashit enable completion gulp
gulp enabled with priority 350.

 2022-05-20 08:01:15 ⌚  36f05b99f861 in /my-project
○ → bashit restart 

 2022-05-20 08:01:21 ⌚  36f05b99f861 in /my-project
○ → gulp 
default  help     todo     

 2022-05-20 08:01:21 ⌚  36f05b99f861 in /my-project
○ → gulp 
default  help     todo     

 2022-05-20 08:01:21 ⌚  36f05b99f861 in /my-project
○ → gulp 
[08:01:40] Using gulpfile /my-project/gulpfile.js
[08:01:40] Starting 'default'...
[08:01:40] Finished 'default' after 2.39 ms

I have tested this in GNU bash, version 5.1.16(1)-release (x86_64-alpine-linux-musl)

@tbhaxor tbhaxor mentioned this pull request May 20, 2022
8 tasks
@tbhaxor
Copy link
Contributor Author

tbhaxor commented Feb 23, 2023

Timeout

@tbhaxor tbhaxor closed this Feb 23, 2023
@tbhaxor tbhaxor deleted the improve/gulp-completion branch February 23, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants