Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.11 #728

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Support Python 3.11 #728

merged 1 commit into from
Dec 4, 2022

Conversation

AntonOfTheWoods
Copy link
Contributor

No description provided.

ayaka14732
ayaka14732 reviewed Oct 25, 2022
View reviewed changes
@AntonOfTheWoods AntonOfTheWoods force-pushed the py311 branch 2 times, most recently from 6f6cfe9 to 1dca56a Compare October 25, 2022 01:55
@AntonOfTheWoods
Copy link
Contributor Author

Sorry @ayaka14732 , I push-forced and overwrote your change (and have since fixed it).

We are going to have to wait for Github to publish 3.11 images unfortunately. Actually even Docker only just (less than 20 minutes ago) published their own images, even though the Hub page said they were available several hours ago...

@AntonOfTheWoods AntonOfTheWoods marked this pull request as draft October 25, 2022 02:40
@groverlynn groverlynn mentioned this pull request Nov 22, 2022
Merged
@AntonOfTheWoods
Add python 3.11 support (BYVoid#727)
09a23f3 
As the Anaconda folks can take months (or even years) to support new
versions of python, also move to the conda-forge upstream repo, which is
both much quicker and also the source of truth for the standard
packages.
@AntonOfTheWoods AntonOfTheWoods changed the title Support Python 3.11, Apple silicon + minor fixes Support Python 3.11 Dec 2, 2022
@AntonOfTheWoods
Copy link
Contributor Author

@ayaka14732 , please have a look. I have removed the version bump to isolate this python-specific change.

One thing is that the building gets done with anaconda ;-<. This means that we either have to wait for them to support python 3.11, or use conda-forge. It may take them months or even years to update - the company apparently doesn't care at all (ContinuumIO/anaconda-issues#13082).

In this commit/PR, I have migrated to conda-forge as the source for the python executable. Upstream gets their versions from there, but haven't done so yet.

@AntonOfTheWoods AntonOfTheWoods marked this pull request as ready for review December 2, 2022 07:01
@AntonOfTheWoods
Copy link
Contributor Author

Thanks @ayaka14732 , so we are now just waiting for an extra +1 to merge? If this is ok, I will also open a release PR with all the changelogs.

ayaka14732
ayaka14732 approved these changes Dec 4, 2022
View reviewed changes
Copy link
Collaborator

@ayaka14732 ayaka14732 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good to merge now

@ayaka14732 ayaka14732 merged commit 07d2f75 into BYVoid:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayaka14732 ayaka14732 ayaka14732 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonOfTheWoods @ayaka14732