Fix authority parsing logic #3261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jmprieur
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Thanks @JoshLozensky
We probably need to add a unit test that would fail before the bug was fixed?
ksaaf
reviewed
Feb 26, 2025
bgavrilMS
reviewed
Feb 26, 2025
bgavrilMS
reviewed
Feb 26, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Added :) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
bgavrilMS
approved these changes
Feb 27, 2025
JoshLozensky
force-pushed
the
lozensky/AuthorityHttpsCheck
branch
from
ead93b8 to
2dce84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes logic in the
ParseAuthorityIfNecessarymethod in theMergedOptionsclass to fix a bug where the check on theindexTenantalways evaluates to true.Originally, there had been a bug here because the '/' chars in the scheme prefix of the URI were not taken into account leading to false positives when checking for the presence of the instance/tenantId
This PR went into Id Web in 3.1.0 and attempted to address the above bug but accidentally created another where the
indexTenant>=0 condition always evaluated to true as its min possible value was 7.The current PR fixes this by making the starting index of the authority URI scheme-agnostic and uses that dynamic value to compare against the
indexTenantvariable.