Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect authority parsing in MergedOptions.ParseAuthorityIfNecessary #3262

Open
JoshLozensky opened this issue Feb 25, 2025 · 0 comments · May be fixed by #3261
Open

Incorrect authority parsing in MergedOptions.ParseAuthorityIfNecessary #3262

JoshLozensky opened this issue Feb 25, 2025 · 0 comments · May be fixed by #3261
Assignees
Labels
bug Something isn't working P2

Comments

@JoshLozensky
Copy link
Contributor

JoshLozensky commented Feb 25, 2025

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

3.7.1

Web app

Not Applicable

Web API

Not Applicable

Token cache serialization

Not Applicable

Description

A bug introduced in 3.1.0 is during splitting of the authority.
The condition will always be true here

This was originally brought up by @yzhoholiev in another issue but isn't relevant to the original post so creating this to track it.

Reproduction steps

Use a config that needs authority parsing

Error message

No response

Id Web logs

No response

Relevant code snippets

N/A

Regression

No response

Expected behavior

This condition should actually switch on the presence of tenantId/instance rather than be always true

@JoshLozensky JoshLozensky self-assigned this Feb 25, 2025
@JoshLozensky JoshLozensky linked a pull request Feb 25, 2025 that will close this issue
@bgavrilMS bgavrilMS added the P2 label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants