-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable broker support on Linux platform #5086
Conversation
src/client/Microsoft.Identity.Client.Broker/Microsoft.Identity.Client.Broker.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.
Files not reviewed (5)
- Directory.Packages.props: Language not supported
- NuGet.Config: Language not supported
- src/client/Microsoft.Identity.Client.Broker/Microsoft.Identity.Client.Broker.csproj: Language not supported
- tests/devapps/WAM/NetWSLWam/Properties/launchSettings.json: Language not supported
- tests/devapps/WAM/NetWSLWam/test.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs:59
- [nitpick] The method name 'IsRunningOnWsl' could be more descriptive. Consider renaming it to 'IsRunningOnWindowsSubsystemForLinux'.
public static bool IsRunningOnWsl()
src/client/Microsoft.Identity.Client.Broker/RuntimeBroker.cs:129
- Replace the debug log statement with a proper logging mechanism: _logger.Info("Runtime Broker AcquireTokenInteractiveAsync");
Console.WriteLine("Runtime Broker AcquireTokenInteractiveAsync");
src/client/Microsoft.Identity.Client/PlatformsCommon/Shared/DesktopOsHelper.cs
Outdated
Show resolved
Hide resolved
src/client/Microsoft.Identity.Client/ApiConfig/BrokerOptions.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/RuntimeBrokerTests.cs
Outdated
Show resolved
Hide resolved
tests/Microsoft.Identity.Test.Integration.netcore/Infrastructure/MsalAssert.cs
Outdated
Show resolved
Hide resolved
...s/Microsoft.Identity.Test.LabInfrastructure/Microsoft.Identity.Test.LabInfrastructure.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work @xinyuxu1026, some comments
- few tests have asserts commented out
- really like to understand the CI variables check on product code
- still no dll checks on the pipeline after building the test project
- linux file check may need a exception handler
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation