Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup azure pipeline and add e2e #60

Merged
merged 2 commits into from
Sep 12, 2020
Merged

test: setup azure pipeline and add e2e #60

merged 2 commits into from
Sep 12, 2020

Conversation

aramase
Copy link
Member

@aramase aramase commented Jul 27, 2020 •
edited
Loading

  • Adds azure pipeline to run tests
  • Removes pipeline for circle CI
  • Switches to using go modules

fixes #56

@aramase aramase force-pushed the azure-pipeline branch 7 times, most recently from 9bbc5d1 to fb092a5 Compare July 27, 2020 21:23
@aramase
Copy link
Member Author

aramase commented Jul 28, 2020

Need to remove circle CI build after this PR is merged.

@aramase aramase requested a review from ritazh July 28, 2020 01:04
ritazh
ritazh reviewed Aug 29, 2020
View reviewed changes
@ritazh
Copy link
Member

ritazh commented Aug 29, 2020

just one nit. Everything else LGTM

ritazh
ritazh approved these changes Sep 12, 2020
View reviewed changes
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ritazh ritazh merged commit c4f8b28 into master Sep 12, 2020
@aramase aramase deleted the azure-pipeline branch September 12, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritazh ritazh ritazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch to using go modules
2 participants
@aramase @ritazh