Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add arm64 support for images #116

Merged
merged 1 commit into from
Oct 13, 2021
Merged

feat: add arm64 support for images #116

merged 1 commit into from
Oct 13, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Oct 6, 2021

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Reason for Change:

  • Adds arm64 support for images
  • Makes the image build reproducible

Issue Fixed:

fixes #114

Notes for Reviewers:

@aramase aramase force-pushed the arm64 branch 9 times, most recently from 3fb1bec to 79ae377 Compare October 12, 2021 18:57
@aramase aramase requested a review from sozercan October 12, 2021 19:12
@aramase aramase marked this pull request as ready for review October 12, 2021 19:12
sozercan
sozercan previously approved these changes Oct 13, 2021
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, LGTM after

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit 57b116e into master Oct 13, 2021
@aramase aramase deleted the arm64 branch October 13, 2021 19:36
bingosummer added a commit to bingosummer/kubernetes-kms that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ARM64 image
2 participants