Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics #104

Merged
merged 33 commits into from
Jun 7, 2021
Merged

Metrics #104

merged 33 commits into from
Jun 7, 2021

Conversation

nilekhc
Copy link
Contributor

@nilekhc nilekhc commented May 27, 2021

Reason for Change:

Adds otel instrumentation for custom metrics. Following custom metrics are added

kms_request

Issue Fixed:

fixes #96
Notes for Reviewers:

nilekhc added 2 commits May 27, 2021 16:33
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc requested a review from aramase May 27, 2021 23:40
@nilekhc
Copy link
Contributor Author

nilekhc commented May 28, 2021

Sample metrics output:

# HELP decrypt_duration_sec Distribution of how long it took to decrypt request
# TYPE decrypt_duration_sec histogram
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.1"} 97
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.2"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.3"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.4"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.5"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="1"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="1.5"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="2"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="2.5"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="3"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="5"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="10"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="15"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="30"} 100
decrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="+Inf"} 100
decrypt_duration_sec_sum{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 4.4068910269999995
decrypt_duration_sec_count{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 100
# HELP encrypt_duration_sec Distribution of how long it took to encrypt request
# TYPE encrypt_duration_sec histogram
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.1"} 93
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.2"} 99
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.3"} 99
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.4"} 99
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="0.5"} 99
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="1"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="1.5"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="2"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="2.5"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="3"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="5"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="10"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="15"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="30"} 100
encrypt_duration_sec_bucket{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0",le="+Inf"} 100
encrypt_duration_sec_sum{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 5.661030241000001
encrypt_duration_sec_count{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 100
# HELP total_decrypt Total number of Decrypt requests
# TYPE total_decrypt counter
total_decrypt{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 100
# HELP total_encrypt Total number of Encrypt requests
# TYPE total_encrypt counter
total_encrypt{os_type="darwin",service_name="unknown_service:__debug_bin",telemetry_sdk_language="go",telemetry_sdk_name="opentelemetry",telemetry_sdk_version="0.20.0"} 100

@nilekhc nilekhc requested review from aramase and sozercan May 28, 2021 23:17
@nilekhc nilekhc requested a review from sozercan June 1, 2021 17:48
@nilekhc nilekhc requested a review from aramase June 2, 2021 21:08
Copy link
Member

@aramase aramase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few small nits, but otherwise lgtm!

@nilekhc nilekhc requested a review from aramase June 4, 2021 17:10
@aramase aramase added the do-not-merge/work-in-progress work in progress label Jun 4, 2021
@nilekhc nilekhc requested a review from aramase June 4, 2021 17:38
@aramase aramase removed the do-not-merge/work-in-progress work in progress label Jun 4, 2021
@nilekhc nilekhc merged commit 0de672d into Azure:master Jun 7, 2021
@nilekhc nilekhc deleted the metrics branch June 7, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metrics
3 participants