fix: handles key vault name with double quotes. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilekh Chaudhari <1626598+nilekhc@users.noreply.github.com>
aramase
reviewed
May 26, 2021
pkg/plugin/keyvault.go
Outdated
| @@ -115,6 +116,10 @@ func getVaultURL(vaultName string, azureEnvironment *azure.Environment) (vaultUR | |||
| if len(vaultName) < 3 || len(vaultName) > 24 { | |||
| return nil, fmt.Errorf("invalid vault name: %q, must be between 3 and 24 chars", vaultName) | |||
| } | |||
|
|
|||
| //Trim quotes from vault name. https://github.com/Azure/kubernetes-kms/issues/85 | |||
| vaultName = strings.Trim(vaultName, "\"") | |||
There was a problem hiding this comment.
We'll need this for keyName and keyVersion too. Also, there could be a possibility of additional whitespace in the string. To account for that, we could probably define a sanitize function, that'll take a string, trim quotes, trim space and return the sanitized string.
aramase
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nilekh Chaudhari 1626598+nilekhc@users.noreply.github.com
Reason for Change:
Removes double quotes from keyvault name.
Issue Fixed:
fixes #85
Notes for Reviewers: