[UX][GitHub] azcopy cp fails if the destination path is at the root of the file system (i.e. /) #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siminsavani-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
vibhansa-msft,
tasherif-msft,
seanmcc-msft and
pranavmalik-msft
as code owners
gapra-msft
reviewed
Feb 22, 2024
seanmcc-msft
assigned pranavmalik-msft, seanmcc-msft and gapra-msft and unassigned pranavmalik-msft and seanmcc-msft
gapra-msft
reviewed
Feb 22, 2024
gapra-msft
reviewed
Feb 22, 2024
gapra-msft
approved these changes
Mar 7, 2024
pranavmalik-msft
approved these changes
Mar 12, 2024
vibhansa-msft
approved these changes
Mar 12, 2024
|
Please sync with main before merging, else looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While AzCopy is acting as expected (does not transfer to root directory, i.e: "/"), AzCopy crashes with an out of bounds error at line 59 in writeThoughFile.go, especially in Linux.
When AzCopy gets
lastIndexbystrings.LastIndex(destinationPath, DeterminePathSeparator(destinationPath)), theLastIndex()method will either return a valid index or-1if last index is not found in the string. In cases thatlastIndexis not found (in other words, lastIndex is equal to -1), we should handle this gracefully by a clear error message instead of letting AzCopy crash as seen in this GitHub issue: #2036.When this occurs, the error message is reported in the log and the console output shows that transfer has failed:
Final Job Status: Failed.FYI: the workaround is to download the file under a valid directory (i.e. "/tmp", "/home", etc.) and then users can move the downloaded file where they desire as we don't plan on supporting root directories.
Resolves #2036