-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify very large block size to force put blob instead of stage block/put block list #2561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Work is mostly fine, I have some comments regarding defaults, overriding, etc.
I was mostly copying the pattern of how we deal with BlockBlobBLockSize. We should probably log that we updated it, you're right. I will fix that for both BlockBlobBlockSize and this new variable |
You're right. I think I was planning to use DefaultPutBlobSize then decided it's probably better to use the block size so that customers don't experience any "breaking changes" from this PR. I will get rid of the DefaultPutBLobSize var and update the comment. |
No description provided.