[RCA Repair Item]Retried deletes should ignore 404 errors #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavmalik-msft
requested review from
gapra-msft,
adreed-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft,
tasherif-msft and
seanmcc-msft
as code owners
pranavmalik-msft
changed the title
nakulkar-msft
previously approved these changes
Jan 29, 2024
vibhansa-msft
previously approved these changes
Feb 1, 2024
siminsavani-msft
previously approved these changes
Feb 7, 2024
There was a problem hiding this comment.
thanks for including a clear description @pranavmalik-msft !
|
Don't forget to change the base branch to main btw! |
pranavmalik-msft
dismissed
siminsavani-msft’s stale review
The base branch was changed.
pranavmalik-msft
dismissed stale reviews from vibhansa-msft and nakulkar-msft
The base branch was changed.
siminsavani-msft
approved these changes
Feb 7, 2024
gapra-msft
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request aims to resolve the reported issue related to Azcopy, where it erroneously reports failures in cases of a 404 error, despite a successful background delete operation. The proposed fix involves disregarding 404 errors and treating them as successful operations.
Changes: