Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ACL copying with Blob #2525

Merged
merged 10 commits into from
Mar 12, 2024
Merged

Fix ACL copying with Blob #2525

merged 10 commits into from
Mar 12, 2024

Conversation

adreed-msft
Copy link
Member

Somewhere along the way, when we moved to generating clients in cmd, we opted to generate a dfs and blob client when working with BlobFS, but we didn't do so for working with Blob.

This

  1. Creates a DFS and Blob client as long as we're working with either resource, because they're the same resource
  2. Enables some feature-parity with sync where specifying include-directory-stubs is used whenever persisting permissions on Blob, because we know that we're working with HNS and will encounter folders
  3. Allows our testing suite to actually target BlobFS literally, rather than pretending.

gapra-msft
gapra-msft previously approved these changes Jan 4, 2024
View reviewed changes
tasherif-msft
tasherif-msft previously approved these changes Jan 9, 2024
View reviewed changes
nakulkar-msft
nakulkar-msft previously approved these changes Jan 10, 2024
View reviewed changes
@seanmcc-msft seanmcc-msft added this to the 10.24 milestone Jan 11, 2024
@adreed-msft adreed-msft dismissed stale reviews from tasherif-msft and gapra-msft via 61321c6 January 12, 2024 00:33
@gapra-msft gapra-msft mentioned this pull request Jan 20, 2024
Closed
gapra-msft
gapra-msft previously approved these changes Feb 8, 2024
View reviewed changes
@adreed-msft adreed-msft force-pushed the adreed/provide-dfs-service-from-blob branch from 61321c6 to 4ee889e Compare February 23, 2024 02:58
@adreed-msft adreed-msft changed the base branch from dev to main February 23, 2024 02:58
@adreed-msft adreed-msft dismissed stale reviews from gapra-msft and nakulkar-msft February 23, 2024 02:58

The base branch was changed.

siminsavani-msft
siminsavani-msft approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@siminsavani-msft siminsavani-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some questions about the e2e tests modifications, otherwise, LGTM!

@adreed-msft adreed-msft force-pushed the adreed/provide-dfs-service-from-blob branch from ed27fb5 to 48dab67 Compare March 11, 2024 17:52
@adreed-msft adreed-msft force-pushed the adreed/provide-dfs-service-from-blob branch from 48dab67 to 6a3956b Compare March 11, 2024 18:58
@adreed-msft adreed-msft merged commit dbe015e into main Mar 12, 2024
17 checks passed
@gapra-msft gapra-msft deleted the adreed/provide-dfs-service-from-blob branch October 18, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siminsavani-msft siminsavani-msft siminsavani-msft approved these changes

@gapra-msft gapra-msft gapra-msft approved these changes

@nakulkar-msft nakulkar-msft nakulkar-msft left review comments

@tasherif-msft tasherif-msft tasherif-msft left review comments

@vibhansa-msft vibhansa-msft Awaiting requested review from vibhansa-msft vibhansa-msft is a code owner

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@pranavmalik-msft pranavmalik-msft Awaiting requested review from pranavmalik-msft

Assignees

@nakulkar-msft nakulkar-msft

@tasherif-msft tasherif-msft

Labels
pr-ready-for-review
Projects
None yet
Milestone
10.24
Development

Successfully merging this pull request may close these issues.
6 participants
@adreed-msft @gapra-msft @nakulkar-msft @tasherif-msft @siminsavani-msft @seanmcc-msft