Fix container->container behaviour w/ preserve-permissions #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adreed-msft
requested review from
gapra-msft,
nakulkar-msft,
siminsavani-msft,
vibhansa-msft and
tasherif-msft
as code owners
adreed-msft
force-pushed
the
adreed/file-share-copy-fix
branch
from
47e733d to
8000541
Compare
adreed-msft
force-pushed
the
adreed/file-share-copy-fix
branch
from
48bcb82 to
73dfd67
Compare
adreed-msft
force-pushed
the
adreed/file-share-copy-fix
branch
from
73dfd67 to
1114e1e
Compare
gapra-msft
reviewed
Apr 14, 2023
siminsavani-msft
approved these changes
Apr 17, 2023
gapra-msft
approved these changes
Apr 19, 2023
adreed-msft
added a commit
that referenced
this pull request
Apr 20, 2023
* Disable lookup before starting traverser (#2157) * Disable lookup before starting traverser * Update comment * Update comment2 * Fix container->container behaviour w/ preserve-permissions (#2150) * Fix container->container behaviour * Fix log uploading in test suite * Fix tests * Fix data race in hash-based sync (#2159) * Improve --from-to docs (#2165) * Improve --from-to docs * Indicate optionality * 10.18.1 release (#2171) --------- Co-authored-by: Narasimha Kulkarni <nakulkar@microsoft.com>
adreed-msft
added a commit
that referenced
this pull request
Apr 20, 2023
* Fix container->container behaviour * Fix log uploading in test suite * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 10.18, we incorrectly adjusted the behavior of container->container w/ preserve-permissions to no longer strip the top directory. The behavior has been adjusted to use as-subdir to resolve the regression.
Linked to #2141