Added CodeQL (#2009)

* Added linting file

* Upgrade codeql to v2

* Fix incorrect conversion between integer types

* Fix GCP URL parts

.github/workflows/codeql-analysis.yml

@@ -0,0 +1,67 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  pull_request:
+    branches: [ main, dev ]
+  push:
+    branches: [ main, dev ]
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'go' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://git.io/codeql-language-support
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v2
+
+      # Initializes the CodeQL tools for scanning.
+      - name: Initialize CodeQL
+        uses: github/codeql-action/init@v2
+        with:
+          languages: ${{ matrix.language }}
+          # If you wish to specify custom queries, you can do so here or in a config file.
+          # By default, queries listed here will override any specified in a config file.
+          # Prefix the list here with "+" to use these queries and those in the config file.
+          # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+      # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+      # If this step fails, then you should remove it and run the build manually (see below)
+      - name: Autobuild
+        uses: github/codeql-action/autobuild@v2
+
+      # ℹ️ Command-line programs to run using the OS shell.
+      # 📚 https://git.io/JvXDl
+
+      # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+      #    and modify them (or add more) to build your code if your project
+      #    uses a compiled language
+
+      #- run: |
+      #   make bootstrap
+      #   make release
+
+      - name: Perform CodeQL Analysis
+        uses: github/codeql-action/analyze@v2

cmd/benchmark.go

@@ -273,15 +273,15 @@ func (h benchmarkSourceHelper) FromUrl(s string) (fileCount uint, bytesPerFile i
 	pieces[0] = strings.Split(pieces[0], "=")[1]
 	pieces[1] = strings.Split(pieces[1], "=")[1]
 	pieces[2] = strings.Split(pieces[2], "=")[1]
-	fc, err := strconv.ParseUint(pieces[0], 10, 64)
+	fc, err := strconv.ParseUint(pieces[0], 10, 32)
 	if err != nil {
 		return 0, 0, 0, err
 	}
 	bpf, err := strconv.ParseInt(pieces[1], 10, 64)
 	if err != nil {
 		return 0, 0, 0, err
 	}
-	nf, err := strconv.ParseUint(pieces[2], 10, 64)
+	nf, err := strconv.ParseUint(pieces[2], 10, 32)
 	if err != nil {
 		return 0, 0, 0, err
 	}

common/gcpURLParts.go

@@ -7,8 +7,8 @@ import (
 	"strings"
 )
 
-//GCPURLParts structure is used to parse and hold the different
-//components of GCP Object/Service/Bucket URL
+// GCPURLParts structure is used to parse and hold the different
+// components of GCP Object/Service/Bucket URL
 type GCPURLParts struct {
 	Scheme         string
 	Host           string
@@ -17,13 +17,13 @@ type GCPURLParts struct {
 	UnparsedParams string
 }
 
-const gcpHostPattern = "^storage.cloud.google.com"
+const gcpHostPattern = "^storage\\.cloud\\.google\\.com"
 const invalidGCPURLErrorMessage = "Invalid GCP URL"
 const gcpEssentialHostPart = "google.com"
 
 var gcpHostRegex = regexp.MustCompile(gcpHostPattern)
 
-//IsGCPURL validates whether a given URL is a valid GCP Object/Service/Bucket URL
+// IsGCPURL validates whether a given URL is a valid GCP Object/Service/Bucket URL
 func IsGCPURL(u url.URL) bool {
 	if _, isGCPURL := findGCPURLMatches(strings.ToLower(u.Host)); isGCPURL {
 		return true
@@ -39,8 +39,8 @@ func findGCPURLMatches(lower string) ([]string, bool) {
 	return matches, true
 }
 
-//NewGCPURLParts processes the given URL and returns a valid GCPURLParts
-//structure that contains all the necessary components.
+// NewGCPURLParts processes the given URL and returns a valid GCPURLParts
+// structure that contains all the necessary components.
 func NewGCPURLParts(u url.URL) (GCPURLParts, error) {
 	host := strings.ToLower(u.Host)
 	_, isGCPURL := findGCPURLMatches(host)
@@ -70,7 +70,7 @@ func NewGCPURLParts(u url.URL) (GCPURLParts, error) {
 	return up, nil
 }
 
-//URL returns a valid net/url.URL object initialised from the components of GCP URL
+// URL returns a valid net/url.URL object initialised from the components of GCP URL
 func (gUrl *GCPURLParts) URL() url.URL {
 	path := ""
 
@@ -118,8 +118,8 @@ func (gUrl *GCPURLParts) IsObjectSyntactically() bool {
 	return false
 }
 
-//IsDirectorySyntactically returns true if the given GCPURLParts
-//points to a directory or not based on the path.
+// IsDirectorySyntactically returns true if the given GCPURLParts
+// points to a directory or not based on the path.
 func (gUrl *GCPURLParts) IsDirectorySyntactically() bool {
 	if gUrl.IsObjectSyntactically() && strings.HasSuffix(gUrl.ObjectKey, "/") {
 		return true

common/gcpURLParts_test.go

@@ -47,3 +47,22 @@ func (s *gcpURLPartsTestSuite) TestGCPURLParseNegative(c *chk.C) {
 	c.Assert(err, chk.NotNil)
 	c.Assert(strings.Contains(err.Error(), invalidGCPURLErrorMessage), chk.Equals, true)
 }
+
+func (s *gcpURLPartsTestSuite) TestIsGCPURL(c *chk.C) {
+	u, _ := url.Parse("http://storage.cloud.google.com/bucket/keyname/")
+	isGCP := IsGCPURL(*u)
+	c.Assert(isGCP, chk.Equals, true)
+
+	// Negative Test Cases
+	u, _ = url.Parse("http://storage.cloudxgoogle.com/bucket/keyname/")
+	isGCP = IsGCPURL(*u)
+	c.Assert(isGCP, chk.Equals, false)
+
+	u, _ = url.Parse("http://storage.cloud.googlexcom/bucket/keyname/")
+	isGCP = IsGCPURL(*u)
+	c.Assert(isGCP, chk.Equals, false)
+
+	u, _ = url.Parse("http://storagexcloud.google.com/bucket/keyname/")
+	isGCP = IsGCPURL(*u)
+	c.Assert(isGCP, chk.Equals, false)
+}

ste/concurrency.go

@@ -49,7 +49,7 @@ func (i *ConfiguredInt) GetDescription() string {
 func tryNewConfiguredInt(envVar common.EnvironmentVariable) *ConfiguredInt {
 	override := common.GetLifecycleMgr().GetEnvironmentVariable(envVar)
 	if override != "" {
-		val, err := strconv.ParseInt(override, 10, 64)
+		val, err := strconv.ParseInt(override, 10, 32)
 		if err != nil {
 			log.Fatalf("error parsing the env %s %q failed with error %v",
 				envVar.Name, override, err)