Change from Set/GetNamedSecurityInfo to Nt{Query,Set}SecurityInfo #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsha-msft
reviewed
Jan 10, 2022
| uint32(len(buf)), | ||
| &bufLen) | ||
| }, &buf, &bufLen) | ||
|
|
There was a problem hiding this comment.
Can we verify that changes are working as expected by any unit test?
|
TODO: an automated test to double check |
adreed-msft
force-pushed
the
adreed/fix-acl-api
branch
from
79f9a8c to
c39fee4
Compare
mohsha-msft
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way that we were obtaining and setting ACLs to ensure accuracy. Set/GetNamedSecurityInfo would do some merging, which made it not entirely accurate for backups. However, the Nt{Query,Set}SecurityInfo APIs do not do merging, and allow for considerably more accurate preservation of ACLs.