-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] [STG 98] Added support for x-ms-file-request-intent
for Blob Copy APIs
#39578
[Storage] [STG 98] Added support for x-ms-file-request-intent
for Blob Copy APIs
#39578
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some minor comments on tests.
/azp run python - pullrequest |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6b0e358
into
Azure:feature/storage-stg98
This PR contains the following changes:
azure-storage-file-share>=12.20.1
todev_requirements.txt
, the latest GA File Share release, for testing compatibilitysource_token_intent
to sendx-ms-file-request-intent
and the appropriate validation for async copy (which is not a part of the feature)As of the first iteration, only the
upload_blob_from_url
tests has been recorded to check ifdev_requirements.txt
dependency is scaffolded properly. In addition, I've groupedappend_block_from_url
tests withtest_block_blob.py
andtest_block_blob_async.py
because they're all block blobs to reduce code duplication. I'm open to moving this totest_append_blob.py
andtest_append_blob_async.py
respectively, after the naming, features, and testing structures have been reviewed. Thanks!