Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] [STG 98] Added support for x-ms-file-request-intent for Blob Copy APIs #39578

Conversation

weirongw23-msft
Copy link
Member

@weirongw23-msft weirongw23-msft commented Feb 5, 2025

This PR contains the following changes:

  1. Created helper functions (sync and async) to manage bearer token credential strings, refactored some existing code to match this pattern
  2. Created helper functions to manage creating source files with OAuth
  3. Added azure-storage-file-share>=12.20.1 to dev_requirements.txt, the latest GA File Share release, for testing compatibility
  4. Added kwargs for source_token_intent to send x-ms-file-request-intent and the appropriate validation for async copy (which is not a part of the feature)
  5. Misc. fixes like moving closing parentheses to a new line

As of the first iteration, only the upload_blob_from_url tests has been recorded to check if dev_requirements.txt dependency is scaffolded properly. In addition, I've grouped append_block_from_url tests with test_block_blob.py and test_block_blob_async.py because they're all block blobs to reduce code duplication. I'm open to moving this to test_append_blob.py and test_append_blob_async.py respectively, after the naming, features, and testing structures have been reviewed. Thanks!

:shipit:

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Feb 5, 2025
@weirongw23-msft weirongw23-msft marked this pull request as ready for review February 5, 2025 14:06
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-storage-blob

Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some minor comments on tests.

@weirongw23-msft
Copy link
Member Author

/azp run python - pullrequest

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@weirongw23-msft weirongw23-msft merged commit 6b0e358 into Azure:feature/storage-stg98 Feb 13, 2025
23 checks passed
@weirongw23-msft weirongw23-msft deleted the weirongw23/file-to-blob-copy branch February 13, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants