[Storage] [STG 98] NFS over REST 98 #39438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirongw23-msft
requested review from
annatisch,
jalauzon-msft and
vincenttran-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vincenttran-msft
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
LGTM, nice work! The one feedback is that we are missing Setup, Act, Assert headers (I see that they are missing in the whole file so I didn't catch that the first time around, but it may be worth adding especially since some of these tests are a little hard to look at without them (there's alot going on 😵💫)). But conceptually things are good!
jalauzon-msft
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Premium File's NFS APIs:
create_symbolic_link,get_symbolic_link