Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication]Enable managed identity in ACScommunication resource sdk #37566

Merged
Merged
Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
af95b71
Update autorest mark down to latest OpenApi spec
Jul 11, 2023
dcb828d
Merge branch 'main' into joelen/acs-managed-identity-public-preview
Jul 11, 2023
8fc7e5a
initial code generation with new Swagger spec hash
Jul 12, 2023
96981ae
remove bugged format and generate code
Jul 19, 2023
f9e85ed
update spec link to remote link
Jul 19, 2023
3b216b1
Adding test scenario for MI
jorge-beauregard Jul 31, 2023
87dd544
Merge branch 'main' into joelen/acs-managed-identity-public-preview
Aug 1, 2023
5c42cb6
Update Export Api
Aug 2, 2023
aaac637
Update to most recent spec hash
Aug 2, 2023
6dd754f
Update Sample Snippets
Aug 2, 2023
d13b8c9
Add Managed Identity tests session records assets
Aug 3, 2023
2f74639
Merge branch 'main' into joelen/acs-managed-identity-public-preview
Aug 18, 2023
e2f6291
Re-enforce resourceId format
Aug 18, 2023
ef15be6
updated test recording
Aug 18, 2023
edeb3af
updated recordings
Aug 18, 2023
8b25d10
updated-recordings
Aug 19, 2023
9647e7a
fix tests and Update test recordings
Sep 4, 2023
0f8beb6
Update changelog release history
Sep 8, 2023
7dd59a3
Provide backward compatibility to accomodate breaking change
Sep 8, 2023
0f8679b
remove param from fallback overload
Sep 8, 2023
bba4253
Update customize folder with communication service resource data
Sep 8, 2023
d5bfcb7
fix build issues
Sep 8, 2023
7200557
fix build issues
Sep 8, 2023
7398d66
export api to support older resource data
Sep 11, 2023
3dd35dd
Merge branch 'main' into joelen/acs-managed-identity-public-preview
Sep 11, 2023
61ab525
fix build issues
Sep 11, 2023
cebff12
Update release date of `1.2.0-beta.2`
archerzz Sep 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
# Release History

## 1.2.0-beta.2 (Unreleased)
## 1.2.0-beta.2 (2023-09-07)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes
- Added support for System Assigned, User Assigned and SystemAndUserAssigned Managed Identity

## 1.2.0-beta.1 (2023-05-29)

Expand Down Expand Up @@ -118,7 +114,7 @@ Guidance to migrate from previous version of Azure Management SDK
Example: Create A Communication Service Instance:

Before upgrade:
```C#
```C#
using Azure.Identity;
using Azure.ResourceManager.Communication;
using Azure.ResourceManager.Communication.Models;
Expand All @@ -131,7 +127,7 @@ var resourceGroupName = "myResourceGroupName";
var resourceName = "myResource";
var resource = new CommunicationServiceResource { Location = "Global", DataLocation = "UnitedStates" };
var operation = await communicationServiceClient.CommunicationService.StartCreateOrUpdateAsync(resourceGroupName, resourceName, resource);
await operation.WaitForCompletionAsync();
await operation.WaitForCompletionAsync();
```

After upgrade:
Expand Down Expand Up @@ -161,7 +157,7 @@ CommunicationService communicationService = communicationServiceLro.Value;
```

## 1.0.0 (2021-03-29)
This release is the first stable release of the management library for Azure Communication Services.
This release is the first stable release of the management library for Azure Communication Services.

Minor changes since the public preview release:
- CheckNameAvailability has been added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ public partial class CommunicationServiceResourceData : Azure.ResourceManager.Mo
public CommunicationServiceResourceData(Azure.Core.AzureLocation location) : base (default(Azure.Core.AzureLocation)) { }
public string DataLocation { get { throw null; } set { } }
public string HostName { get { throw null; } }
public Azure.ResourceManager.Models.ManagedServiceIdentity Identity { get { throw null; } set { } }
public System.Guid? ImmutableResourceId { get { throw null; } }
public System.Collections.Generic.IList<string> LinkedDomains { get { throw null; } }
public Azure.Core.ResourceIdentifier NotificationHubId { get { throw null; } }
Expand Down Expand Up @@ -216,6 +217,7 @@ public static partial class ArmCommunicationModelFactory
public static Azure.ResourceManager.Communication.CommunicationDomainResourceData CommunicationDomainResourceData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, System.Collections.Generic.IDictionary<string, string> tags = null, Azure.Core.AzureLocation location = default(Azure.Core.AzureLocation), Azure.ResourceManager.Communication.Models.DomainProvisioningState? provisioningState = default(Azure.ResourceManager.Communication.Models.DomainProvisioningState?), string dataLocation = null, string fromSenderDomain = null, string mailFromSenderDomain = null, Azure.ResourceManager.Communication.Models.DomainManagement? domainManagement = default(Azure.ResourceManager.Communication.Models.DomainManagement?), Azure.ResourceManager.Communication.Models.DomainPropertiesVerificationStates verificationStates = null, Azure.ResourceManager.Communication.Models.DomainPropertiesVerificationRecords verificationRecords = null, Azure.ResourceManager.Communication.Models.UserEngagementTracking? userEngagementTracking = default(Azure.ResourceManager.Communication.Models.UserEngagementTracking?)) { throw null; }
public static Azure.ResourceManager.Communication.Models.CommunicationNameAvailabilityResult CommunicationNameAvailabilityResult(bool? isNameAvailable = default(bool?), Azure.ResourceManager.Communication.Models.CommunicationNameAvailabilityReason? reason = default(Azure.ResourceManager.Communication.Models.CommunicationNameAvailabilityReason?), string message = null) { throw null; }
public static Azure.ResourceManager.Communication.Models.CommunicationServiceKeys CommunicationServiceKeys(string primaryKey = null, string secondaryKey = null, string primaryConnectionString = null, string secondaryConnectionString = null) { throw null; }
public static Azure.ResourceManager.Communication.CommunicationServiceResourceData CommunicationServiceResourceData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, System.Collections.Generic.IDictionary<string, string> tags = null, Azure.Core.AzureLocation location = default(Azure.Core.AzureLocation), Azure.ResourceManager.Models.ManagedServiceIdentity identity = null, Azure.ResourceManager.Communication.Models.CommunicationServicesProvisioningState? provisioningState = default(Azure.ResourceManager.Communication.Models.CommunicationServicesProvisioningState?), string hostName = null, string dataLocation = null, Azure.Core.ResourceIdentifier notificationHubId = null, string version = null, System.Guid? immutableResourceId = default(System.Guid?), System.Collections.Generic.IEnumerable<string> linkedDomains = null) { throw null; }
public static Azure.ResourceManager.Communication.CommunicationServiceResourceData CommunicationServiceResourceData(Azure.Core.ResourceIdentifier id = null, string name = null, Azure.Core.ResourceType resourceType = default(Azure.Core.ResourceType), Azure.ResourceManager.Models.SystemData systemData = null, System.Collections.Generic.IDictionary<string, string> tags = null, Azure.Core.AzureLocation location = default(Azure.Core.AzureLocation), Azure.ResourceManager.Communication.Models.CommunicationServicesProvisioningState? provisioningState = default(Azure.ResourceManager.Communication.Models.CommunicationServicesProvisioningState?), string hostName = null, string dataLocation = null, Azure.Core.ResourceIdentifier notificationHubId = null, string version = null, System.Guid? immutableResourceId = default(System.Guid?), System.Collections.Generic.IEnumerable<string> linkedDomains = null) { throw null; }
public static Azure.ResourceManager.Communication.Models.DomainPropertiesVerificationRecords DomainPropertiesVerificationRecords(Azure.ResourceManager.Communication.Models.VerificationDnsRecord domain = null, Azure.ResourceManager.Communication.Models.VerificationDnsRecord spf = null, Azure.ResourceManager.Communication.Models.VerificationDnsRecord dkim = null, Azure.ResourceManager.Communication.Models.VerificationDnsRecord dkim2 = null, Azure.ResourceManager.Communication.Models.VerificationDnsRecord dmarc = null) { throw null; }
public static Azure.ResourceManager.Communication.Models.DomainPropertiesVerificationStates DomainPropertiesVerificationStates(Azure.ResourceManager.Communication.Models.DomainVerificationStatusRecord domain = null, Azure.ResourceManager.Communication.Models.DomainVerificationStatusRecord spf = null, Azure.ResourceManager.Communication.Models.DomainVerificationStatusRecord dkim = null, Azure.ResourceManager.Communication.Models.DomainVerificationStatusRecord dkim2 = null, Azure.ResourceManager.Communication.Models.DomainVerificationStatusRecord dmarc = null) { throw null; }
Expand Down Expand Up @@ -311,6 +313,7 @@ public CommunicationServiceNameAvailabilityContent() { }
public partial class CommunicationServiceResourcePatch : Azure.ResourceManager.Communication.Models.CommunicationAcceptTags
{
public CommunicationServiceResourcePatch() { }
public Azure.ResourceManager.Models.ManagedServiceIdentity Identity { get { throw null; } set { } }
public System.Collections.Generic.IList<string> LinkedDomains { get { throw null; } }
}
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "net",
"TagPrefix": "net/communication/Azure.ResourceManager.Communication",
"Tag": "net/communication/Azure.ResourceManager.Communication_7b093c3b15"
"Tag": "net/communication/Azure.ResourceManager.Communication_696b7aac1e"
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading