-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloudConfigurationManager.GetSetting exposes configuration setting values to tracing/logging (and is quite verbose) #653
Comments
CloudConfigurationManager.GetSetting should not cause logging of actual values of configuration settings as discussed in Azure#653 .
@bradygaster please assign for triage |
As of nuget package v2.0.3 this is still an issue for me - has this fix been released yet? |
@mleyb, I am afraid the last configuration manager release (2.0.3 - the one you are using) is from 2013 and predates my change. We are still using our own drop-in CloudConfigurationManager for that reason. I will try to find out who might be able to answer if and when there might be a new release. |
Are you planning to push out a new nuget package with this fix in any time soon? |
Fixed in version 3.0.0. Please update Microsoft Azure Configuration Manager nuget package. |
Amazing news! Thanks a lot 👍 |
....hang on a minute - this doesn't seem to work at all with Azure SDK v2.5 when running a simple worker role in the emulator, or in Azure. I just get null values for cloud service settings??? app.config seems to work OK but not the service settings |
How do we turn off tracing for CloudConfigurationManager all together? |
CloudConfigurationManager.GetSetting should be used to retrieve settings from app.config as well as Azure cscfgs in a transparent fashion (especially useful when deploying to websites and cloud services).
The internal implementation (i.e. AzureApplicationSettings.GetValue) logs (via Trace.WriteLine) if the setting has been found or not using a certain configuration mechanism. This logging cannot be prevented which makes the output quite verbose which is unwanted (as discussed here and here).
My main concern is that it also logs the actual setting value. This is a potential security issue as data like blob or SQL connection strings may be written to diagnostics storage or other trace listeners.
#653
The text was updated successfully, but these errors were encountered: