Skip to content

Commit

Permalink
Fix flaky tests in azcore (#11853)
Browse files Browse the repository at this point in the history
Includes updated dependency on internal module to fix race condition.
  • Loading branch information
jhendrixMSFT authored Jul 23, 2020
1 parent 9c5af4f commit 2f59e72
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion sdk/azcore/go.mod
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module github.com/Azure/azure-sdk-for-go/sdk/azcore

require github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.0
require github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.1

go 1.13
4 changes: 2 additions & 2 deletions sdk/azcore/go.sum
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.0 h1:cLpVMIkXC/umSP9DMz9I6FttDWJAsmvhpaB6MlkagGY=
github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.0/go.mod h1:Q+TCQnSr+clUU0JU+xrHZ3slYCxw17AOFdvWFpQXjAY=
github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.1 h1:xY9/wUJ8PcxmTEJ6z+0qKuj9rb3Aw9nhiL+ik5evR/g=
github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.1/go.mod h1:Q+TCQnSr+clUU0JU+xrHZ3slYCxw17AOFdvWFpQXjAY=
4 changes: 2 additions & 2 deletions sdk/azcore/response_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ func TestRetryAfter(t *testing.T) {
t.Fatal("expected retry-after value from date")
}
// d will not be exactly 600 seconds but it will be close
if d/time.Second != 599 {
t.Fatalf("expected ~600 seconds, got %d", d/time.Second)
if s := d / time.Second; s < 598 || s > 602 {
t.Fatalf("expected ~600 seconds, got %d", s)
}
}

Expand Down

0 comments on commit 2f59e72

Please sign in to comment.