Bring semaphore synchronization updates in retry delegating handler to LTS #3148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather than n times (#2209) #2202 previously: retry(retry(open) + send/receive/etc) now: retry(open + send/receive/etc) This is as opposed to doing something like: retry(open) + retry(send/receive/etc) because the connection may be lost after the retry(open) block has finished, and we don't want to keep trying to send/receive/etc without checking that the connection is open first
* Decouple client open-close semaphore from callback subscription semaphore * Cancel pending operations when CloseAsync() is invoked
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft and
patilsnr
as code owners
abhipsaMisra
force-pushed
the
abmisr/semaphoreLts
branch
from
a98e5d5 to
e8f8ea6
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2209 : fix(iot-dev): Fix bug where client's retry policy applied n^2 times rather than n times
#3135 : Decouple client open-close semaphore from callback subscription semaphore