Add migration doc misses found in API review #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms,
patilsnr and
schoims
as code owners
drwill-ms
force-pushed
the
drwill/migration-guide-updates
branch
from
78dd07e to
94b6224
Compare
drwill-ms
force-pushed
the
drwill/migration-guide-updates
branch
from
94b6224 to
8345e30
Compare
brycewang-microsoft
approved these changes
Feb 9, 2023
patilsnr
approved these changes
Feb 9, 2023
| | `Twin.StatusUpdatedOn` | `ClientTwin.StatusUpdatedOnUtc` | See¹ | | ||
| | `Twin.LastActivityOn` | `ClientTwin.LastActiveOnUtc` | See¹ | | ||
| | `TwinCollection` | `ClientTwinProperties` | See² | | ||
| | `TwinCollection` | `ClientTwinProperties` | "Client" is a word we often use to indicate the device- or module-side of the data-plane.² | |
There was a problem hiding this comment.
is the dash meant to be here? After device
There was a problem hiding this comment.
Yes, because device-side is a suffixed word, and we're sharing the suffix with module-.
I think this is considered proper English, but I could be wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.