Remove ClientRuntime dependency and add Newtonsoft.Json package #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schoims
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Jan 18, 2023
| @@ -64,10 +64,11 @@ | |||
| <PackageReference Include="Azure.Core" Version="1.26.0" /> | |||
| <PackageReference Include="Microsoft.Azure.Amqp" Version="2.5.12" /> | |||
| <PackageReference Include="MQTTnet" Version="4.1.2.350" /> | |||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> | |||
There was a problem hiding this comment.
I can update it to 13.0.2. I chose 13.0.1 for consistency only since other SDKs use this version.
drwill-ms
approved these changes
Jan 18, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
approved these changes
Jan 18, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the v2 migration, HTTP has been removed as a transport option, resulting in Microsoft.Rest.ClientRuntime no longer being required as a dependency of Provisioning Client SDK. However, its dependency is still utilized, so this change has been introduced.