Remove telemetry batch operation over MQTT #3000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
abhipsaMisra
commented
Dec 2, 2022
abhipsaMisra
commented
Dec 2, 2022
patilsnr
approved these changes
Dec 2, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
commented
Dec 2, 2022
drwill-ms
reviewed
Dec 3, 2022
drwill-ms
reviewed
Dec 3, 2022
Co-authored-by: David R. Williamson <drwill@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
Dec 3, 2022
drwill-ms
reviewed
Dec 3, 2022
| // is the recommended pattern for sending large numbers of messages over an asynchronous | ||
| // protocol like MQTT | ||
| await Task.WhenAll(messages.Select(x => SendTelemetryAsync(x, cancellationToken))).ConfigureAwait(false); | ||
| throw new InvalidOperationException("Batch telemetry is supported only over AMQP."); |
There was a problem hiding this comment.
I feel like the MQTT transport layer shouldn't know about the other transports. A more cohesive message would be that it is not supported over MQTT. Thoughts?
There was a problem hiding this comment.
I see your point. I think we'll still need to guide users down the correct path.
How about:
throw new InvalidOperationException("This operation is not supported over this protocol. Please refer to the doc comments for additional details.");
drwill-ms
approved these changes
Dec 3, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.