Remove out-of-support targets from test matrix #2976
Conversation
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
|
Need to update the supported platforms file, and probably the migraiton guide. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
abhipsaMisra
force-pushed
the
abmisr/outOfSupport
branch
from
6d6b6ff to
a3eff77
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
abhipsaMisra
force-pushed
the
abmisr/outOfSupport
branch
from
a3eff77 to
7f344f5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
supported_platforms.md
Outdated
| @@ -20,6 +20,8 @@ Nightly test platform details: | |||
| .NET versions tested on | |||
| - .NET 7.0 | |||
| - .NET 6.0 | |||
| - .NET Core 3.1 | |||
| - .NET Framework 4.6.1 (only IoT Hub SDKs) | |||
There was a problem hiding this comment.
Why only Hub SDKs? Is net461 not .netstandard2.0 compliant?
There was a problem hiding this comment.
net461 isn't fully compliant with ns2.0. For this reason I think we should test against net472 instead (which is what we have been doing). What do you think? @drwill-ms
From https://learn.microsoft.com/en-us/dotnet/standard/net-standard?tabs=net-standard-2-0#select-net-standard-version:
The versions listed here represent the rules that NuGet uses to determine whether a given .NET Standard library is applicable. While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.
There was a problem hiding this comment.
Wow, I wonder why track2 tests with it then.
I'd say stick with 472 for now, but ask the azure sdk team about it.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Remove out-of-support targets from test matrix (#2976) * Update supported_platforms.md Co-authored-by: David R. Williamson <drwill@microsoft.com> * Update supported_platforms.md Co-authored-by: David R. Williamson <drwill@microsoft.com> Co-authored-by: David R. Williamson <drwill@microsoft.com>
With this new version we can update out test matrix to only test against supported targets. Targets that have reached EOL will no longer be tested against.
Support matrix: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
Note: .NET 3.1 is also set to reach EOL in Dec 22. Should we remove this target from our testing matrix?