Cancel amqp token refresher as a part of transport cleanup #2935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
abhipsaMisra
force-pushed
the
abmisr/cancelRefresher
branch
from
d4e62ab to
177a505
Compare
patilsnr
approved these changes
Nov 4, 2022
drwill-ms
reviewed
Nov 4, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 4, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Nov 4, 2022
abhipsaMisra
commented
Nov 8, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
patilsnr
approved these changes
Nov 8, 2022
|
Optimistic sign off, would recommend waiting for another approval from someone more experienced. |
drwill-ms
reviewed
Nov 8, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 8, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 8, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 8, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Nov 8, 2022
iothub/device/src/Transport/Amqp/AmqpAuthenticationRefresher.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Nov 8, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
abhipsaMisra
added a commit
that referenced
this pull request
Dec 19, 2022
This was referenced Dec 19, 2022
abhipsaMisra
added a commit
that referenced
this pull request
Dec 19, 2022
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amqp sas token refresher runs as a background unmonitored task. We need to ensure that the task is cancelled as a part of transport layer cleanup.
Related: #2339 , maybe #2351