Add retry policies into DPS service #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewang-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
reviewed
Oct 29, 2022
| IndividualEnrollments = new IndividualEnrollmentsClient(_provisioningConnectionString, _contractApiHttp); | ||
| EnrollmentGroups = new EnrollmentGroupsClient(_provisioningConnectionString, _contractApiHttp); | ||
| DeviceRegistrationStates = new DeviceRegistrationStatesClient(_provisioningConnectionString, _contractApiHttp); | ||
| _retryPolicy = clientOptions.RetryPolicy ?? new ProvisioningServiceNoRetry(); |
There was a problem hiding this comment.
Why no retry by default?
There was a problem hiding this comment.
No, the default retry policy would be exponential backoff.
ProvisioningServiceNoRetry would be used when RetryPolicy is set to null.
drwill-ms
approved these changes
Oct 29, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
Loggingfor DPS service client in this PR.