Add retry policies into DPS device #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewang-microsoft
requested review from
drwill-ms,
timtay-microsoft,
abhipsaMisra,
andyk-ms,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
| @@ -45,7 +45,7 @@ public void RetryPolicyBase_ObservesInifiniteRetries() | |||
| [TestMethod] | |||
| [DataRow(true)] | |||
| [DataRow(false)] | |||
| public void RetryPolicyBase_IotHubException_ReturnsTrueWhenTransient(bool isTransient) | |||
| public void RetryPolicyBase_IotHubServiceException_ReturnsTrueWhenTransient(bool isTransient) | |||
There was a problem hiding this comment.
correcting the test method name as we don't have IotHubException context any more.
drwill-ms
reviewed
Oct 28, 2022
drwill-ms
reviewed
Oct 28, 2022
provisioning/device/src/RetryPolicies/ProvisioningClientExponentialBackoffRetryPolicy.cs
Show resolved
Hide resolved
drwill-ms
reviewed
Oct 28, 2022
provisioning/device/src/RetryPolicies/ProvisioningClientFixedDelayRetryPolicy.cs
Outdated
Show resolved
Hide resolved
drwill-ms
reviewed
Oct 28, 2022
provisioning/device/src/RetryPolicies/ProvisioningClientRetryPolicyBase.cs
Outdated
Show resolved
Hide resolved
drwill-ms
approved these changes
Oct 28, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -858,8 +861,8 @@ public static ProvisioningClientOptions CreateProvisioningClientOptionsFromName( | |||
| if (transportSettings is IotHubClientMqttSettings) | |||
| { | |||
| return transportSettings.Protocol == IotHubClientTransportProtocol.Tcp | |||
| ? new ProvisioningClientOptions(new ProvisioningClientAmqpSettings(ProvisioningClientTransportProtocol.Tcp)) | |||
There was a problem hiding this comment.
this was wrong, so correct.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will have another PR to add retry policies for DPS service.