Make tests more resilient to service latency #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwill-ms
requested review from
timtay-microsoft,
abhipsaMisra,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
drwill-ms
commented
Oct 18, 2022
drwill-ms
commented
Oct 18, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
patilsnr
approved these changes
Oct 18, 2022
timtay-microsoft
approved these changes
Oct 18, 2022
drwill-ms
force-pushed
the
drwill/test-timeout
branch
from
71167f4 to
c1d63a5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
commented
Oct 18, 2022
abhipsaMisra
approved these changes
Oct 18, 2022
drwill-ms
force-pushed
the
drwill/test-timeout
branch
from
4bbe1f4 to
5f0961a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
commented
Oct 18, 2022
brycewang-microsoft
approved these changes
Oct 18, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmahmood-microsoft
approved these changes
Oct 18, 2022
drwill-ms
force-pushed
the
drwill/test-timeout
branch
from
a09746b to
cc57f0c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/test-timeout
branch
from
4aed1bd to
12fe173
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
force-pushed
the
drwill/test-timeout
branch
from
cd61a6a to
53d21d8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
brycewang-microsoft
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR had to run the pipelines 5 times because some tests that use this flow kept failing after retries. But the retry settings, at least with the latest retry policy, are too meager. The tests didn't run for more than a few seconds, so this should give them more time in the event that the device registry is running slow.