This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Go coding style #693
Merged
Go coding style #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanknox
force-pushed
the
go_coding_style
branch
2 times, most recently
from
a3026bc to
726b433
Compare
colemickens
reviewed
May 31, 2017
Makefile
Outdated
| @@ -23,7 +23,7 @@ _build: | |||
| go build -v -ldflags="-X github.com/Azure/acs-engine/cmd.BuildSHA=${VERSION} -X github.com/Azure/acs-engine/cmd.BuildTime=${BUILD}" | |||
| cd test/acs-engine-test; go build -v | |||
|
|
|||
| build: prereqs _build | |||
| build: _build | |||
There was a problem hiding this comment.
Might as well remove _build and replace with build. I had kept build so that a naive make or make build would work out of the box. If build doesn't automatically invoke glide, then the user has to know to run an additional step. But I'm fine with it either way.
|
@acs-bot test this please |
seanknox
force-pushed
the
go_coding_style
branch
from
5835729 to
fdcc925
Compare
|
Rebased off of master and removed the |
|
@acs-bot test this please |
added 7 commits
June 23, 2017 09:11
seanknox
force-pushed
the
go_coding_style
branch
from
b018c38 to
1528b96
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces go coding standards to the project and automation to run as part of CI and tests to enforce them.
Add documentation that the project follows Go coding style standards closely so
go fmtcan take care of most formatting issues and end bike shedding.We should also follow the conventions recommended by go lint and gometalinter.
make test-styleruns static validations and linting checksAddress all static validation and linting errors
make cialso runstest-styleFixes #692
This change is